ssbc / ssb-bfe

Binary Field Encodings (BFE) for Secure Scuttlebutt (SSB)
3 stars 1 forks source link

add tests around throw cases #18

Closed mixmix closed 3 years ago

mixmix commented 3 years ago

This PR:

arj03 commented 3 years ago

This looks great to me, will wait and see if @staltz has any input before merging.

mixmix commented 3 years ago

Couldn't reply to one of your things for some reason on mobile. Here is my reply ;

This handles .box,.box1,.box2 etc etc

They encode.box decides what it actually knows how to encode

Eg .box30 will currently fail

staltz commented 3 years ago

Couldn't reply to one of your things for some reason on mobile. Here is my reply ;

This handles .box,.box1,.box2 etc etc

Ok, good! :)

mixmix commented 3 years ago

Thanks for the review, merging this now