search

ssbc / ssb-buttwoo

A new binary feed format for SSB
3 stars 0 forks source link

rewrite using ssb-feed-format #2

Closed staltz closed 2 years ago

staltz commented 2 years ago

Part of https://github.com/ssbc/ssb-db2/pull/347

@arj03 I'm curious how performance will be with this implementation. I couldn't test the perf myself because the benchmarks in ssb-db2 don't use add() (which would trigger addBatch()), so I think you'd have to test this in ssb-ebt with that "3s" test you have.

arj03 commented 2 years ago

Will get to you on this tonight or tomorrow

arj03 commented 2 years ago

I'm 95% sure this is good. I'll have to do a little more testing and then I'll do the ebt test before pressing the big green button. Time for dinner now :)

arj03 commented 2 years ago

Pushed up a test because I wanted to make sure that parent works correctly with the feed format messages

staltz commented 2 years ago

Thanks for reviewing! Lots of changes going on lately. But this should be one of the last ones.

staltz commented 2 years ago

Can you publish ssb-buttwoo@0.3.0 or give me publish rights?

arj03 commented 2 years ago

@staltz you have been invited :)