Use port override in connections config

ssbc / ssb-config

standard configuration for ssb

MIT License

23 stars 18 forks source link

Use port override in connections config #19

Closed christianbundy closed 5 years ago

christianbundy commented 5 years ago

This resolves an issue where sbot server --port 1234 creates a configuration where:

config.port === 1234
config.connections.incoming.net[].port === 8008

Discussion on SSB: %vVojK87pNKHqLG99n4Sk9qfdju4FV83hUOrcU/x+iZA=.sha256

cryptix commented 5 years ago

hrm... we might want to make a note about the possible obsoletion of --port? it's not really clear which one you configure if there are multiple connections , I think.

than again we need to un-break the previous behavior so I'm merging this.

cryptix commented 5 years ago

published as v2.3.3

arj03 commented 5 years ago

Thanks @cryptix. Agree

arj03 commented 5 years ago

And also @christianbundy for fixing ❤️