add keys to config that's auto-loaded

ssbc / ssb-config

standard configuration for ssb

MIT License

23 stars 18 forks source link

add keys to config that's auto-loaded #29

Closed mixmix closed 5 years ago

mixmix commented 5 years ago

In every client app I've ever touched this property keys is added manually to the config after ssb-config has done all its setup.

I don't understand why this isn't part of the standard stuff loaded as part of ssb-config ... so here it is!

dominictarr commented 5 years ago

sounds very reasonable, but did you actually confirm that this works with all those things? do ssb-server tests still pass, can you run patch* etc

mixmix commented 5 years ago

I'll run those tests now then merge + publish if it's working fine

dominictarr commented 5 years ago

:+1:

dominictarr commented 5 years ago

@mixmix did you test this?

mixmix commented 5 years ago

I was waiting on the other stuff before piling more in. Now you've made a major bump and we got the testing working I'll go ahead and get this merged asap

mixmix commented 5 years ago

:heavy_check_mark: ssb-server tests pass

merging and publishing as 3.1.0