Closed mixmix closed 5 years ago
The purpose of the PR is to close over some dangerous looseness in the connection setting behaviour.
When I say "legacy config" in this PR I mean config.host config.port config.ws, while "new config" is connections.incoming
config.host
config.port
config.ws
connections.incoming
host
port
ws
ws.port
TODO:
ssb-server
patchbay
@dominictarr here's a juicy testing PR :watermelon: :sweat_drops:
EDIT: this adds tests AND changes behaviour
merged into 3.2.0
The purpose of the PR is to close over some dangerous looseness in the connection setting behaviour.
When I say "legacy config" in this PR I mean
config.host
config.port
config.ws
, while "new config" isconnections.incoming
Possible pathways
host
port
ws
)connections.incoming
is generated based on what you providedhost
,port
,ws.port
are then derived from the thatconnections.incoming
connections.incoming
host
,port
,ws.port
are then derived from the thatconnections.incoming
connections.incoming
port
host
ws
lead to contradictions with your declaredconnections.incoming
an error is thrown.The algorithm
connections.incoming
set thatconfig.host
config.port
config.ws
picked up along the wayconnections.incoming
contradicts the the legacy configthis ensures that legacy setup is always catered for, and also guards against divergence
TODO:
ssb-server
and see if its tests passpatchbay
and see if it runs