Better default ports - Githubissues

ssbc / ssb-config

standard configuration for ssb

MIT License

23 stars 18 forks source link

Better default ports #32

Closed mixmix closed 5 years ago

mixmix commented 5 years ago

The purpose of this PR is to :

:heavy_check_mark: ensure net + ws ports are set to default if not specified in connections.incoming
- note this only fixes the "primary" connection in each case, does not fix multiple net connections missing port
:heavy_check_mark: ensure host and port are not set in the event the user explicitly did not declare an incoming net or ws connection

TODO:

_ test in ssb-server

mixmix commented 5 years ago

@dominictarr this is to address 6fd058f70183bee25afb949806700c7398dbcbd4 :

net and ws should always have a default port, otherwise breaks ssb-server/plugins/local, @mixmix

ssb-config should allow you to _not set port when you're not wanting one set. If ssb-server crashes without a port, then we need to either:

ensure there is a transport from which we're getting a valid port
teach ssb-server to not explode

example edge case : I start an ssb-server with only a socket connection. ssb-server should need no port... and if it does, then I'm suspicious about what it's doing with it

dominictarr commented 5 years ago

:+1:

mixmix commented 5 years ago

Dominic is that an approve and not merge!

I'm fine merging and publishing to save you time if you want. :question:

On Sun, 20 Jan 2019, 16:44 Dominic Tarr, notifications@github.com wrote:

👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ssbc/ssb-config/pull/32#issuecomment-455835160, or mute the thread https://github.com/notifications/unsubscribe-auth/ACitnuF9C1Ty1Y0VQ_1tbaVybHwihqYyks5vE-YYgaJpZM4aI2pA .