only generate/load keys if not specified in overrides

ssbc / ssb-config

standard configuration for ssb

MIT License

23 stars 18 forks source link

only generate/load keys if not specified in overrides #41

Closed mmckegg closed 5 years ago

mmckegg commented 5 years ago

Currently ssb-config will always load or generate the keys and ignore anything passed in as an "override". However this leaves no way to manually specify the keys and disable generation.

This PR changes this behavior so that the key is only automatically loaded/generated if one was not specified in the override (e.g. ssbConfig('some-app', {keys: rootConfig.keys}))

dominictarr commented 5 years ago

would merge this feature, but add tests please so this doesn't get broken in future changes

mixmix commented 5 years ago

@mmckegg bump

christianbundy commented 5 years ago

I think this was resolved in #45, I'm going to close this one now.