search

ssbc / ssb-config

standard configuration for ssb
MIT License
23 stars 18 forks source link

Listening on false #43

Closed christianbundy closed 5 years ago

christianbundy commented 5 years ago

It looks like something changed recently in a not-so-backward-compatible way. See: https://github.com/ssbc/ssb-ooo/pull/3

I'm wondering whether this might have been caused by https://github.com/ssbc/ssb-config/pull/31?

I don't personally mind the change, but I think it snuck in as a minor/patch bump rather than a major version. Could that be right?

Used to work

createSbot({
  port: 34597,
  keys: ssbKeys.generate()
})

Now required

createSbot({
  host: 'localhost',
  port: 34597,
  keys: ssbKeys.generate()
})

cc: @mixmix @dominictarr

christianbundy commented 5 years ago

I'm unable to reproduce now -- closing.

dominictarr commented 5 years ago

if you pass false as the address to a server it should default to '::' or '0.0.0.0' i think