Closed christianbundy closed 4 years ago
@christianbundy I didn't keep up with the latest developments here, so just a a note: keep in mind that omitting host
has security implications, because ti make the server listen on all available IP addresses. You don't ever want to combine this with noauth
. (noauth via websockets is something people want to use on localhost. Exposing it to a local (LAN) or even public IP would be a disaster)
test this and found that it results in sbot.getAddress('local', null)
resulting in 'net:0.0.0.0:8087~shs:AjtDkqLp76adwR5TeYyNpV3AY3zmHXCjU+Zht6rsFIA='
getAddress uses multiserver's stringify, so this is related to that other PR. I don't understand multiserver well enough to know where this should go ):
It seems like The Right Way to go about this is to omit the host entirely so that Node.js can decide on a host automagically:
...but we shouldn't do that until ssb-client knows that an omitted host means "try both
::
and0.0.0.0
". In the meantime, this brings us back to an IPv4-only default config which unbreaks Travis and conforms to the code comments that say: