search

ssbc / ssb-config

standard configuration for ssb
MIT License
23 stars 18 forks source link

Add onion to default outgoing connections and fix ssb-server dep #54

Closed arj03 closed 5 years ago

arj03 commented 5 years ago

I was testing @mixmix's ssb-ahoy and noticed that when enabling and disabling tor-only I would end up with tor connections not working, this is because by default only net outgoing connections are enabled. Instead of added onion to the default in patchbay I think its better to add it here.

CC: @christianbundy as this might also have implications for patchwork.

Also this unbreaks current master as we have a dev-dep on latest?! scuttlebutt and 15 has a breaking change.

christianbundy commented 5 years ago

Sweet! My understanding is that this doesn't change anything for most people (?) but folks with Tor configured will now start connecting to .onion pubs, is that right?

arj03 commented 5 years ago

Exactly. This passes the tests and is relatively safe I think. Would love to get this into the next releases of patchbay and patchwork as they are right around the corner :)

christianbundy commented 5 years ago

:tada: Thanks for putting this together, I'm sure lots of Tor users will be excited about this.