search

ssbc / ssb-config

standard configuration for ssb
MIT License
23 stars 18 forks source link

Change default friends.hops to 2 #66

Closed christianbundy closed 4 years ago

christianbundy commented 4 years ago

This is the default in Patchwork, Patchbay, and Manyverse, and I think it's a reasonable default for ssb-config.

arj03 commented 4 years ago

I still think ssb server should default to 3.

christianbundy commented 4 years ago

I'm comfortable with that, is that something you think we should specify in ssb-server or put in ssb-config?

staltz commented 4 years ago

@arj03 Care to share your argument for the number 3? I'm okay with blocking this PR from merging until there's consensus (to either 2 or 3).

arj03 commented 4 years ago

My reasoning was that for a pub it makes more sense to store a larger part of the network

christianbundy commented 4 years ago

I think that makes sense. I think the decision to make is who ssb-config is for.

My current position is that ssb-config should probably match the needs and expectations of "most people" who use it, which I think is friends.hops = 2, but I'd be totally down to make a PR into ssb-server to specify friends.hops = 3 too. What do y'all think?

arj03 commented 4 years ago

Makes sense

staltz commented 4 years ago

I got convinced that we should keep it to 3 because of the pubs, but with Christian's latest comment I got convinced (again) we should change it to 2, so that the default value is optimizing for what "makes most sense" on the social graph, instead of optimizing for "pubs having enough data". ssb-server with hops 3 makes sense if it's actually used for servers. If it's used for CLIs on desktop, then maybe it should be 2?

This reminds me that ssb-server is just a distribution of plugins. We should probably make another distro "ssb-pub-server" that is optimized for pub servers on the internet.

arj03 commented 4 years ago

Right, https://github.com/ssbc/ssb-minimal-pub-server is focused on pubs. It's just not so well known. It's very much a communication aspect as well.

christianbundy commented 4 years ago

@arj03 Do you think we should wait on merging this?

arj03 commented 4 years ago

I think we should merge this. I'll change the default in minimal pub server afterwards.

This is a good change as its a far better default and I'm really glad that you are making these kind of changes :heart:

christianbundy commented 4 years ago

@arj03 Thanks for the kind words, and thanks for the review. I'll merge now. :rocket: