search

ssbc / ssb-config

standard configuration for ssb
MIT License
23 stars 18 forks source link

Add incoming connection for Unix socket #72

Closed christianbundy closed 4 years ago

christianbundy commented 4 years ago

Problem: The Multiserver plugin exposes a Unix socket by default, and it's way faster on low-end devices and devices that are forced to use JavaScript cryptography, but it isn't enabled in SSB-Config.

Solution: Add a line to set it as an incoming connection, so that it's available by default.

arj03 commented 4 years ago

Won't this overwrite if you defined Unix to be shs?

christianbundy commented 4 years ago

I'm not 100% sure -- I thought this would only be run if .connections.incoming is undefined:

https://github.com/ssbc/ssb-config/blob/f4c455b13bb86c5a1630641bc44bb048d39bbe13/defaults.js#L46-L50

arj03 commented 4 years ago

Maybe the function needs a better name then?

christianbundy commented 4 years ago

I'd merge that PR.

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

arj03 commented 4 years ago

Please go ahead and merge

christianbundy commented 4 years ago

Thanks @arj03!