ssbc / ssb-db2

A new database for secure-scuttlebutt
47 stars 8 forks source link

Error during migration and encoding Integer to BIPF #300

Closed staltz closed 2 years ago

staltz commented 2 years ago

I got this bug report to Manyverse, technical details are:

The person who reported described it as: "Exception during .ssb import."

image

Interpreting the error above, apparently it was encoding some objects (supposedly reading the JSON from flumelog.offset and converting it to BIPF for log.bipf) and it stumbled upon an integer that bad inputs on this line of code:

https://github.com/ssbc/bipf/blob/3e113ae5531a5e1c4bba4098e549342ace2ed7e6/index.js#L28

Would be very useful to know what the JSON record actually was there, but :shrug:

arj03 commented 2 years ago

Hmm seems like it's an unsigned int. This line seems to check for unsigned. So seems to be a bug in bipf?

staltz commented 2 years ago

Spot on! Thanks

staltz commented 2 years ago

I updated Manyverse with bipf 1.5.5, and anyway this was never an ssb-db2 issue, so I'll close.