ssbc / ssb-ebt

secure scuttlebutt replication with epidemic-broadcast-trees
MIT License
18 stars 10 forks source link

Replication limiter #15

Closed pietgeursen closed 4 years ago

pietgeursen commented 5 years ago

Motivation:

manyverse needs the ability to limit the number or peers being replicated to improve performance of the app. This PR integrates the ssb-replication-limiter module I've written to help solve that problem.

Changes in this PR:

Using request(<feedId>, **false**) to pause replication.

Dominic said that using request like this might cause problems with eventual consistency. See this issue for more context.

Until ebt has a better pause feature I'm hoping we can use request like this.

mmckegg commented 5 years ago

About to start using this branch in Patchwork. I'll let ya'll know how it goes.

mmckegg commented 5 years ago

sorry @pietgeursen, made a bit of a mess of the commit history trying to get master merged in (and the merge conflicts properly resolved).

stale[bot] commented 5 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

christianbundy commented 4 years ago

Anything I can do to help this along, or are you waiting from feedback from @staltz and @dominictarr?

staltz commented 4 years ago

I think this is part of a project that was cancelled, so I'm not sure that this code in this state is currently reflecting a fully functional code state that we want to include into master branch. I'm inclined to archiving this PR for future reference once we resume this work.

christianbundy commented 4 years ago

Cool, I would love to merge these improvements but if the PR isn't going to get merged then I'd prefer to just close it. I'm going to close both this and https://github.com/ssbc/ssb-friends/pull/11, please re-open and/or ping me if I've done something rude/wrong.

:heart:

dominictarr commented 4 years ago

if I recall correctly, this was intended to fix a problem with cpu usage, or slow syncing, but once it was ready it turned out it wasn't the problem - the problem was indexing.