Unbermuda - Githubissues

ssbc / ssb-ebt

secure scuttlebutt replication with epidemic-broadcast-trees

MIT License

18 stars 10 forks source link

Unbermuda #45

Closed staltz closed 3 years ago

staltz commented 3 years ago

[x] Remove legacy
[x] Move some integration tests to ssb-replication-scheduler
[x] >=95% test coverage
[x] Test in production
[x] Update readme.md

arj03 commented 3 years ago

This is not for this PR to fix, but one thing that I find confusing about this module is that it has request and block and those 2 have to be called correctly to represent what is 3 states: follow, base, block.

staltz commented 3 years ago

This is not for this PR to fix, but one thing that I find confusing about this module is that it has request and block and those 2 have to be called correctly to represent what is 3 states: follow, base, block.

I agree, I think it was dictated by e-b-t's API with events.follow(state, {id, value}) and events.block(state, {id, target, value}).

staltz commented 3 years ago

Can I get some thumbs ups to merge this and release version ssb-ebt@7.0.0?