Recovery sync does not trigger

[staltz]

Manyverse has some automated tests for benchmarking how long does recovery sync last, and currently it doesn't even trigger.

Reproduction:

• Alice @Ju6ir:
  • Has posted data in the past, but now just recovered her account, so her log is completely empty
  • Running Manyverse on the phone
  • ssb-ebt@7.0.1 (epidemic-broadcast-tree@8.0.4)
  • ssb-db2@2.1.4
• Bob @j08Ken:
  • Has posted data and has replicated with Alice, Bob has lots of stuff
  • Custom secret-stack running on desktop
  • ssb-ebt@7.0.1 (epidemic-broadcast-tree@8.0.4)
  • ssb-db@19.3.1

On startup, Bob logs the output of friends.hops and getVectorClock:

@Ju6ir (Alice) is at hops 1
clock[alice] is 173

Bob automatically connects to LAN peer Alice, and then Bob logs:

ssb:conn-hub connecting to net:192.168.1.105:26831~shs:Ju6irD0MKhroDkcz1FKkc7W8LMIyWYWVqBAo4DTHZnM= +0ms
EBT:conn @Ju6irD0MKhroDkcz1FKkc7W8LMIyWYWVqBAo4DTHZnM=.ed25519
ssb:conn-hub connected to net:192.168.1.105:26831~shs:Ju6irD0MKhroDkcz1FKkc7W8LMIyWYWVqBAo4DTHZnM= +50ms
EBT:recv {
  "@Ju6irD0MKhroDkcz1FKkc7W8LMIyWYWVqBAo4DTHZnM=.ed25519": 0
}
EBT:send { '@Ju6irD0MKhroDkcz1FKkc7W8LMIyWYWVqBAo4DTHZnM=.ed25519': -1 }

Note the last part, EBT:send { '@Ju6ir...': -1 }, I fully expected it to be 173 but actual was -1 which signals (as far as I understand) "will not replicate".

[staltz]

PS: In subsequent connections, Bob logs:

ssb:conn-hub connected to net:192.168.1.105:26831~shs:Ju6irD0MKhroDkcz1FKkc7W8LMIyWYWVqBAo4DTHZnM= +44ms
EBT:recv {}
EBT:send {}

[staltz]

I have tried downgrading Bob to ssb-ebt 5.6.7 (e-b-t 7.0) and the behavior is the same.

[staltz]

KILL ME. I forgot to install ssb-replication-scheduler on Bob.