ssbc / ssb-ebt

secure scuttlebutt replication with epidemic-broadcast-trees
MIT License
18 stars 10 forks source link

dont log "reconnected" e-b-t error #64

Closed staltz closed 2 years ago

staltz commented 2 years ago

Context

In the logs in the terminal when running Manyverse desktop, we get these very often:

rpc.ebt.replicate exception: {
  message: 'reconnected to peer',
  name: 'Error',
  stack: 'Error: reconnected to peer\n' +
    '    at Object.createStream (/data/user/0/se.manyver/files/nodejs-project/index.js:20145:36)\n' +
    '    at /data/user/0/se.manyver/files/nodejs-project/index.js:32001:17\n' +
    '    at Array.forEach (<anonymous>)\n' +
    '    at /data/user/0/se.manyver/files/nodejs-project/index.js:31997:14\n' +
    '    at onReady (/data/user/0/se.manyver/files/nodejs-project/index.js:31940:18)\n' +
    '    at EventEmitter.<anonymous> (/data/user/0/se.manyver/files/nodejs-project/index.js:31996:7)\n' +
    '    at EventEmitter.emit (events.js:326:22)\n' +
    '    at setupRPC (/data/user/0/se.manyver/files/nodejs-project/index.js:73491:17)\n' +
    '    at /data/user/0/se.manyver/files/nodejs-project/index.js:73518:34\n' +
    '    at next (/data/user/0/se.manyver/files/nodejs-project/index.js:34820:14)'
}

Note that the stack traces show Android filesystem paths, while I'm on desktop, so this means the stack trace is from the remote peer (I'll send a PR to e-b-t to fix that later)

Problem

It seems like reconnected to peer is a harmless error that just indicates that the stream was reset, but we're trashing the logs anyway with this quite often.

Solution

Detect reconnected to peer and not log it.