search

ssbc / ssb-ebt

secure scuttlebutt replication with epidemic-broadcast-trees
MIT License
18 stars 10 forks source link

add failing test for pub case #75

Closed mixmix closed 2 years ago

mixmix commented 2 years ago

Mystery :fire: If we tell the pub it wants alice's feed (ebt.request) then connect alice to the pub, NOTHING HAPPENS (i.e. the pub does not replicate alice).

staltz commented 2 years ago

I think the "solution" is the solution, it's just a gotcha. One could say that ssb-ebt should do ssb.ebt.request(ssb.id, true) by default, BUT that would be a breaking change AND it would be less and less true the more we use metafeeds (at some point, your "ssb.id" will be the network identity and this is not going to be a feed and shouldn't be included in ebt).

I think a proper solution would be to document these request on the README. The README currently says

ssb-ebt itself does NOT trigger replication automatically after it's installed, instead, you need to call its API methods yourself (primarily request or block), or use a scheduler module such as ssb-replication-scheduler.

Which is good, but we need to say more. Like, in case you don't want to use ssb-replication-scheduler, how you should call ssb.ebt.request.

mixmix commented 2 years ago

Closing this,, #76 resolves