search

ssbc / ssb-first-aid-kit

A user-friendly app for diagnosing and fixing problems with your Scuttlebutt installation
GNU Affero General Public License v3.0
15 stars 3 forks source link

New architectures: ia32 and arm64. #17

Open soapdog opened 4 years ago

soapdog commented 4 years ago

Added more explicit information to guide building the app. It will build multiple targets for multiple architectures:

Powersource commented 4 years ago

Nice. Does it do cross compilation, i.e. when building for linux, does it built for all 3 targets? Does it produce 3 different appimages then?

Powersource commented 4 years ago

The patchwork pr for my reference https://github.com/ssbc/patchwork/pull/1235

soapdog commented 4 years ago

Nice. Does it do cross compilation, i.e. when building for linux, does it built for all 3 targets? Does it produce 3 different appimages then?

I don't know but maybe trying to run the npm run build and see how it goes.

Powersource commented 4 years ago

So running npm run build on x64 produced both ssb-first-aid-kit-1.3.0.AppImage and ssb-first-aid-kit-1.3.0-arm64.AppImage. I wonder if the arm64 one works :p

I think my plan right now would be to just merge this, publish a pre-release 1.3.1, and then have someone test all the new builds. Could you @soapdog make sure that it all gets tested (by someone)? I don't want it to be untested for too long.

soapdog commented 4 years ago

So running npm run build on x64 produced both ssb-first-aid-kit-1.3.0.AppImage and ssb-first-aid-kit-1.3.0-arm64.AppImage. I wonder if the arm64 one works :p

I think my plan right now would be to just merge this, publish a pre-release 1.3.1, and then have someone test all the new builds. Could you @soapdog make sure that it all gets tested (by someone)? I don't want it to be untested for too long.

I can test Windows on all architectures and Macs. I've asked Cel to test an arm64 AppImage I built and he was kind enough to do it. I will try to setup a Raspberry Pi 4 at home to do these tests as well.

Powersource commented 4 years ago

Nice. So that means I don't have to do the prerelease thing right?

soapdog commented 4 years ago

Nice. So that means I don't have to do the prerelease thing right?

I don't know. I think the best case would be for CI to generate the releases and then we can test.