ssbc / ssb-friend-pub

7 stars 0 forks source link

chill logging #3

Closed mixmix closed 5 years ago

mixmix commented 5 years ago

There was some intense console.log hammering I was experiencing. I was finding it stressful, and noisy, and I noticed I disabled this plugin to be able to do some other work and not have it get in my way.

This respects the intentions of logging by moving the logging into sbot logger.

I'm gong to merge and publish this so this can continue to be in patchbay. I'm happy to revisit what I've done here and change it

mixmix commented 5 years ago

THWARTED by insufficient npm publishing rights!

@arj03 can you publish this change (I've pushed the tags for 1.0.5 up to github already), or give me rights to it. In the meantime the patchbay branch I'm on will just point at master

arj03 commented 5 years ago

Oh hello accidental complexity my old friend :(

@mixmix I gave you access right on npm

Thanks for the fix, looks good btw :)

arj03 commented 5 years ago

Published

mixmix commented 5 years ago

Thanks!

On Wed, 20 Mar 2019, 08:33 Anders Rune Jensen, notifications@github.com wrote:

Published

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ssbc/ssb-friend-pub/pull/3#issuecomment-474544231, or mute the thread https://github.com/notifications/unsubscribe-auth/ACitnpg7C49L0o-d081nbstIo1RqGIalks5vYTumgaJpZM4b7JeI .