search

ssbc / ssb-friends

Manages the SSB social graph
MIT License
23 stars 6 forks source link

update logic so a block overrides follow #24

Closed ahdinosaur closed 5 years ago

ahdinosaur commented 5 years ago

for a possible message

{
  contact: key,
  blocking: true,
  following: false
}

this fixes the interpretation such that the block overrides the follow.

https://github.com/ssbc/ssb-friends/issues/20#issuecomment-449209112

dominictarr commented 5 years ago

I get that it doesn't make any sense that follow takes precedence to block, but what is the reason block take precedence to follow?

also, when proposing a change like this - does it effect any existing messages? (thus does it even need to rebuild the index?)

dominictarr commented 5 years ago

also what is the precedent we are setting here? is it that the interpretation used by patchwork is considered the correct one, or is this the "obvious" solution, and the way I had it not correctly obvious. why not fix it in patchwork?

weird. writing all that it seemed quite angry sounding... but I don't mean that. I don't really care one way or another... I just care about establishing clearly what are the principles we use to make decisions

sorry I see now from @mmckegg's comment. yes he is right. @ahdinosaur please put more context in your PRs!

dominictarr commented 5 years ago

also because blocking/flagging is a truthy option only, a message with {blocking: false, following: true} is still following, which is what we want.

dominictarr commented 5 years ago

merged into 3.1.10