search

ssbc / ssb-friends

Manages the SSB social graph
MIT License
23 stars 6 forks source link

cleaner fix for #37 (race condition) #39

Closed dominictarr closed 5 years ago

dominictarr commented 5 years ago

this is a better way to fix https://github.com/ssbc/ssb-friends/issues/37 @mixmix use pull-cont to return a stream after doing an async thing (waiting for layered to be ready)

also note that the value can legitimately be {} if no edges have been added yet.

mixmix commented 5 years ago

oh yeah, onReady was what I was looking for, thanks @dominictarr !

I did realise {} was a valid return but I weighed that as a lower risk than the erronious {} and no subsequent updates.

Left a note about the README which I think needs resolving, and a learning question but other than that this looks ready to deploy.

dominictarr commented 5 years ago

merged into 4.1.4