search

ssbc / ssb-friends

Manages the SSB social graph
MIT License
23 stars 6 forks source link

legacy.stream() takes no arguments, but { live: true } passed #41

Closed christianbundy closed 3 years ago

christianbundy commented 5 years ago

I saw that TypeScript supports plain old JS so I decided to give it a shot in a random repo. Look what I found!

https://github.com/ssbc/ssb-friends/blob/95a2bebb761ef899f66ecd272e646c3605f0e7f9/index.js#L81

@dominictarr Was the intended behavior here important?

dominictarr commented 5 years ago

it seems that method is always live anyway https://github.com/ssbc/ssb-friends/blob/master/legacy.js#L88-L95

mixmix commented 5 years ago

yeah I noticed this as well Christian

staltz commented 3 years ago

No longer an issue because we removed that API