search

ssbc / ssb-friends

Manages the SSB social graph
MIT License
23 stars 6 forks source link

test that private follows are in the social graph #70

Closed staltz closed 3 years ago

staltz commented 3 years ago

Some good news. I wrote tests, and it turned out that my claim in #43 (quote below) is incorrect, because the tests pass

Currently ssb-friends is blind to private blocks, and if other modules rely on isBlocking, then private blocks will slip through and the blocked authors appear in the UI, etc.

I might still implement the API proposed in https://github.com/ssbc/ssb-friends/issues/43#issuecomment-888294939 but this PR is currently useful because this part of ssb-friends was not tested before.

mixmix commented 3 years ago

LOL, nice!