search

ssbc / ssb-friends

Manages the SSB social graph
MIT License
23 stars 6 forks source link

update ssb-db2 to 3.0.0 #73

Closed staltz closed 2 years ago

staltz commented 2 years ago

Context

There are a bunch of modules (such as ssb-friends), which require ssb-db2. If I update my ssb-db2 dependency to 3.0.0, then all these other modules would still pull in ssb-db2 at 2.x, because of the ^ in ^2.1.0.

Problem and solution

Update ssb-db2 to 3.0.0 even though the breaking change does not affect ssb-friends in any way.

Side comment

I also pinned envelope-spec to 1.0.0 because apparently there was a breaking change from 1.0.0 to 1.1.0, where the tfk.json file was removed. Since ssb-tribes@0.4.1 was importing envelope-spec as ^1.0.0, I was getting an error Error: Cannot find module 'envelope-spec/encoding/tfk.json'.

staltz commented 2 years ago

@arj03 If you don't mind, there are a bunch of modules that need this same kind of boring PR to bump ssb-db2, can I just push the bump commit to master and publish new versions on those modules? Or do you prefer to see the PRs for each?