search

ssbc / ssb-keys

keyfile operations for ssb
36 stars 26 forks source link

Make loadOrCreate accept generate options #101

Closed Powersource closed 1 year ago

Powersource commented 1 year ago

I'm working on https://github.com/ssbc/ssb-tribes2/issues/10 and to do that I need to adapt the tests there. And those tests create their keys with loadOrCreate.

Powersource commented 1 year ago

@staltz @mixmix

Powersource commented 1 year ago

Yep should be non-breaking

Powersource commented 1 year ago

@mixmix @staltz i can't merge, do you want to do that and publish a new version?

staltz commented 1 year ago

As said on the tribes2 PR, I think this change is quite deep in the SSB stack and breaks a strong (legacy) assumption that classic feed format is used everywhere. E.g. there are places where we convert from a multiserver/shs address to SSB ID, by plucking the public base64 and adding @ in front and .ed25519 in the end.

So could we put this PR on hold or close it?

Powersource commented 1 year ago

@staltz why not give the user the option at least? And if not the feed format, this will allow the user to set the key seed too.

staltz commented 1 year ago

Good point

mixmix commented 1 year ago

If this is a non-breaking change @Powersource I recommend we merge + publish Will make sure this is added to npm org

Powersource commented 1 year ago

@mixmix merged now. will you publish?