search

ssbc / ssb-keys

keyfile operations for ssb
36 stars 26 forks source link

make eccjs a devdep #22

Closed dominictarr closed 8 years ago

dominictarr commented 8 years ago

this makes eccjs into a devdep only. I wanted to leave it in the tests, so that we still have the idea of a switchable signature. but, since we don't want to use sjcl, we can drop it, and that will resolve this issue: https://github.com/ssbc/ssb-keys/issues/21

pfrazee commented 8 years ago

:+1:

cryptix commented 8 years ago

I would love to see this merged and published. :heart:

dominictarr commented 8 years ago

now I have the anguish of the decision, do it correctly, make this a breaking change, and then update everything that depends on this, or make this a patch, and let everything update it self.

dominictarr commented 8 years ago

merged into 5.0.0 decided to take the high road.

dominictarr commented 8 years ago

I have updated all the back end modules that depend on this, so I new install of ssb-client or scuttlebot should leave this out. @pfraze can you update patchwork to use ssb-keys@5? then we should be good here

pfrazee commented 8 years ago

Done in https://github.com/ssbc/patchwork/pull/327