search

ssbc / ssb-keys

keyfile operations for ssb
36 stars 26 forks source link

id property is public key regardless of curve #50

Closed ameba23 closed 5 years ago

ameba23 commented 5 years ago

This is a minor edit for clarity and should not give any change in behaviour of ssb-keys as it is now.

For context see %rN1jBwjg3Zhz9qnEoj9gcx//uwKaKQzArVkwMUUiUtg=.sha256

christianbundy commented 5 years ago

For the lazy:

Re: %tr82vmrpl

@peg I didn't know that was there! previously to switching to libsodium we used eccjs. That was kept around for a while (because why delete tests) but then installing eccjs (which needed to be via git) was breaking on @cryptix and @keks's school network, and it was annoying so we just dropped that. I should have changed that line at this time too. It should be @.secp256k1 ... I guess that is '@'+pub+'.'+curve

I'd start with something simpler, i mean, involve less layers.

I'd start by making https://github.com/ssbc/ssb-validate#msg--validatecreatefeed_state-keys-hmac_key-content-timestamp work and then https://github.com/ssbc/ssb-validate#state--validateappendstate-hmac_key-msg

that should probably be enough for ssb-db to work too, but only involves the parts that directly touch signatures and keys.

I'm still not completely familiar what this PR does, or what we were doing previously. Maybe someone else will merge (?) but otherwise I'd love some clarification in the commit message or as an edit/comment on this PR.

dominictarr commented 5 years ago

merged into 7.1.5

dominictarr commented 5 years ago

thanks @ameba23 !