search

ssbc / ssb-keys

keyfile operations for ssb
36 stars 26 forks source link

use tilde version range in package.json dependencies #71

Closed staltz closed 4 years ago

staltz commented 4 years ago

We don't have package-lock.json and the dependencies are specified with a hat ^, so this means the ranges are pretty loose.

Tests are failing in main, and I realized that's because they are installing chloride@2.3.0, because we specified the range "chloride": "^2.2.8".

This PR uses tilde instead of hat, to make the version range more narrow, and thus rejecting chloride@2.3.0, but sticking with chloride@2.2.x. The tests now pass. We should try to support chloride@2.3.0 too, but that's another issue.

staltz commented 4 years ago

Pending on #70 being merged first.

christianbundy commented 4 years ago

Thanks for your work on this and attention to detail. :eyes: