replace Buffer constructor with modern Buffer factories

ssbc / ssb-keys

keyfile operations for ssb

36 stars 26 forks source link

replace Buffer constructor with modern Buffer factories #76

Closed staltz closed 4 years ago

staltz commented 4 years ago

The constructor new Buffer is deprecated in modern versions of Node.js. We replaced these by Buffer.from and Buffer.alloc in secret-stack, but now we should do it here too. This PR also requires Node.js to be at least 5.10.0 (so does secret-stack already do that) in order to guarantee that we can use these Buffer factory functions.

christianbundy commented 4 years ago

Nice! Thanks for fixing this.