search

ssbc / ssb-master

2 stars 3 forks source link

This plugin, if used, should be the first plugin installed #7

Open staltz opened 3 years ago

staltz commented 3 years ago

@cblgh saw some race conditions (that showed up as pull-reader shs timeouts) when ssb-db was loaded before ssb-master. This plugin should warn or panic when it's loaded as anything other than the first plugin.

cc @arj03 @cryptix

staltz commented 3 years ago

I'm not even sure how ssb-server works, because it does not load ssb-master as the first plugin: https://github.com/ssbc/ssb-server/blob/7ca237c4d20025a27ec361973eeb3c19f5a3456b/bin.js#L50

cryptix commented 3 years ago

I just remembered that christian realized this and other ordering dependencies, too and went to the length of randomizing the plugin order:

https://github.com/fraction/flotilla/blob/bed27f19610c5d6838b3c25642a2b1ef48a8cfee/index.js#L6-L37