add specification for v1 tree structure

[staltz]

There's one FIXME to be addressed

[arj03]

This looks really good I think. Easy to read and explains that this is just a tree where the structure can change over time. We probably need to condense this shard math into a reasoning for the 1-byte sharding, my gut feeling is that 256 is a good number.

[staltz]

I updated this to have 16 shards, not 256. Maybe worth taking a look

[mixmix]

The nibble 😂 Very scuttlebutt appropriate. Is 2 bits a "pinch" ?

[staltz]

It's not my invention, actually: https://en.m.wikipedia.org/wiki/Nibble

[arj03]

I updated this to have 16 shards, not 256. Maybe worth taking a look

Could we have some reasoning behind the number in the document? For now it just looks like a magic number :-)

[mixmix]

Or just add "this is a semi magic number, we're just gonna suck it and see"

On Sat, 13 Aug 2022, 19:13 Anders Rune Jensen, @.***> wrote:

I updated this to have 16 shards, not 256. Maybe worth taking a look

Could we have some reasoning behind the number in the document? For now it just looks like a magic number :-)

— Reply to this email directly, view it on GitHub https://github.com/ssbc/ssb-meta-feeds-spec/pull/32#issuecomment-1213890387, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUK3HRVGMYA6H2ND3WBSQ3VY5DKXANCNFSM56BOUNEQ . You are receiving this because your review was requested.Message ID: @.***>

[staltz]

@arj03 @mixmix Ready for a final check. I made these changes and added sharding math to this repo.

[mixmix]

@staltz looks good to me. I don't think it needs a PDF but if you really want to you can :P

[arj03]

End of review, just some smaller things otherwise good to go. I really like the addition of sharding math.

[staltz]

Thanks for reviewing :)