search

ssbc / ssb-meta-feeds

10 stars 0 forks source link

branchstream with root doesn't seem to work #114

Open arj03 opened 1 year ago

arj03 commented 1 year ago

I'm trying to fix this unpin ssb-meta-feeds again in tribes2 and it seems that there is something wrong in branchstream when you pass it a root. This is also not tested as far as I can see. What I'm seeing is that is just returns your whole forest. Instead of just for that root. And this line looks wrong. It basically just tests that you have a seed yourself, not that it correspond to anything within the message.

Anyway this is a vague issue, just wanted to put it out there. I might not have time to look at it for a few days.

arj03 commented 1 year ago

Doesn't seem to be the issue

Powersource commented 1 year ago

made pr with failing test https://github.com/ssbc/ssb-meta-feeds/pull/122