ssbc / ssb-meta-feeds

10 stars 0 forks source link

Branch stream private #85

Closed mixmix closed 1 year ago

mixmix commented 1 year ago

Arj pointed out branchStream does not handle private meta-feed announces. This is important because we use/ will use this to inform which feeds we should be replicating (wait is that true, does branchStream stream other peoples feed trees?).

Anyway, this API should work. I have

  1. written a failing test
  2. started trying to get it passing. Problems:
    • unclear what encryption is being used (is it DMOther style as if recps = [sbot.id] and publishing on rootMF then that's an "other"....)
    • unclear why isDecrypted operator isn't working (no errors, just no decryption, did I use it right?)
mixmix commented 1 year ago

@staltz can you look at the content of this and advise any way to progress this? Was semi-sick today so didn't look into this today but would like to today tmrw

staltz commented 1 year ago

unclear why isDecrypted operator isn't working (no errors, just no decryption, did I use it right?)

Can you clarify what you mean by "isn't working"? (e.g. expected behavior versus actual behavior)

unclear what encryption is being used (is it DMOther style as if recps = [sbot.id] and publishing on rootMF then that's an "other"....)

I think we need to first create a decent API or improvement to findOrCreate which clearly allows specifying encryption. Maybe it should resemble ssb.db.create's opts, like opts.encryptionFormat and opts.recps.

mixmix commented 1 year ago

Picking up the API change for encryption here: https://github.com/ssbc/ssb-meta-feeds/pull/89

mixmix commented 1 year ago

This is on hold while the API for encrypted metafeed stuff is pinned down