search

ssbc / ssb-meta-feeds

10 stars 0 forks source link

updateLookup has nasty edge cases #91

Open mixmix opened 1 year ago

mixmix commented 1 year ago

in lookup.js

  function updateLookup(msg) {
    const { type, subfeed, metafeed } = msg.value.content

    // Update roots
    if (!detailsLookup.has(metafeed)) {

      // !detailsLookup.has(metafeed) !== "metafeed is a root)
      // this assumes that we have replicated the metafeed tree in the order
      // that it was created.

Need to watch for this being a problem if we do any fancy out of order replication