search

ssbc / ssb-meta-feeds

10 stars 0 forks source link

main located at root/v1/:shard/main branch #94

Closed staltz closed 1 year ago

staltz commented 1 year ago

Context

I'm working on ssb-replication-scheduler to make it understand the v1 tree structure, and it expects all feeds to be in paths root/v1/:shard/___.

Problem

ssb-meta-feeds was still doing root/main. See also https://github.com/ssbc/ssb-meta-feeds-spec/issues/35

Solution

When the root metafeed is created, publish the main as a metafeed/add/existing under root/v1/:shard/main.

1st :x: 2nd :heavy_check_mark:

mixmix commented 1 year ago

Good idea. Will review logic closely when at computer

staltz commented 1 year ago

Feedback: there were two changes made in this PR which could have been seperated into 2 PRs to smooth reviewing:

Yeah, you're right

we need to make sure this change is recorded in the "migration" spec

Indeed!

staltz commented 1 year ago

I addressed the chili by answering your comment, and then I did the code style changes.

mixmix commented 1 year ago

If I misunderstood that announce thing that's fine. Main thing I wanted to check was that we hadn't missed a side effect of changing where and how we attach the main feed.

The mobile ui sucks, so:

approve :+1: