search

ssbc / ssb-meta-feeds

10 stars 0 forks source link

flexy definition of group recp #97

Closed mixmix closed 1 year ago

mixmix commented 1 year ago

hit a problem, needed this

mixmix commented 1 year ago

@staltz this is a good point. I should have left a note in the code (and now have). The reason we're checking recps is because we don't have a clear specification for how non-groupId recps should work. i.e. if I put a feedId in... tell me how I use that to map to a keyScheme in meta-feeds? Should I always use the rootMF? If we don't then we will have to try 100x more decryptions because any encrypted message could be DM'ing ANY of our subfeeds.

UNDER-specified => locked down

Recap from https://github.com/ssbc/ssb-meta-feeds/pull/89 image

mixmix commented 1 year ago

Opened an issue https://github.com/ssbc/ssb-meta-feeds-migration/issues/4

staltz commented 1 year ago

Mmm, sorry Mix, I still don't understand why this logic would belong in this module.

if I put a feedId in... tell me how I use that to map to a keyScheme in meta-feeds? Should I always use the rootMF?

Suppose you're using ssb-meta-feeds inside a module called ssb-foo-bar. Then the recps selected inside ssb-foo-bar are passed to ssb-meta-feeds, which just redirects them down to ssb-box2, which in turn does some validation and then redirects them to ssb-keyring, which also does some validation albeit different kind of validation (e.g. can't do a DM between two keys you own).

graph LR;
  ssb-foo-bar -- recps --> ssb-meta-feeds -- recps --> ssb-box2 -- recps --> ssb-keyring

My point is that validation should happen in ssb-box2 and ssb-keyring, and that it's ssb-foo-bar's responsibility for choosing the friend's rootMF if they want to announce a private subfeed that only the friend's rootMF can know about. So I'm saying that ssb-meta-feeds shouldn't do any recps validation.

UNDER-specified => locked down

What does this mean?

staltz commented 1 year ago

For the sake of getting things done, I pushed commit https://github.com/ssbc/ssb-meta-feeds/commit/d894b1ed6a0911e06e48dd42ecfd3c24f184edac to master which removes validation of recps. This PR was last commented on 16 days ago, and we have to move a lot faster than that, so I just made a decision.

We can keep discussing this idea and it's possible to revert the decision in the future if we want.