get({ id, timeout}) does not respect timeout

ssbc / ssb-ooo

retrive ssb messages Out Of Order

MIT License

14 stars 4 forks source link

get({ id, timeout}) does not respect timeout #5

Closed christianbundy closed 5 years ago

christianbundy commented 5 years ago

I haven't tested this (!) but reading this code it looks like we're not actually checking opts.timeout anywhere, whereas the readme specifies that the option is passed.

dominictarr commented 5 years ago

ssb-ooo is just a wrapper around gossip-query, which handles the timeout: https://github.com/dominictarr/gossip-query/commit/9d00808f4b3ec97d8b96094dc50682993a1e00fe