search

ssbc / ssb-peer-invites

A new ssb invite system to create invites without having a pub
MIT License
26 stars 2 forks source link

expose getNearbyPubs method, and fix some stuff #21

Closed dominictarr closed 5 years ago

dominictarr commented 5 years ago

@mixmix I noticed that the invite message you posted in %1vXsHzVorHMF34cvKQu26y243J/F5rcSmqYOzMQkCq8=.sha256 had too many pubs, and also some didn't actually support peer-invites. the main problem was the pubs returned did not get sorted correctly, and also pubs that can't help should be filtered out.

dominictarr commented 5 years ago

@mixmix oh I made this PR before I saw your one: https://github.com/ssbc/ssb-peer-invites/pull/19

I merged yours into this

mixmix commented 5 years ago

Thanks for being so into this Dominic. I'm really keen to push on this and get it live. Your help catching these edge cases makes a big difference

On Mon, 1 Jul 2019, 07:17 Dominic Tarr, notifications@github.com wrote:

@mixmix https://github.com/mixmix oh I made this PR before I saw your one: #19 https://github.com/ssbc/ssb-peer-invites/pull/19

I merged yours into this

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ssbc/ssb-peer-invites/pull/21?email_source=notifications&email_token=AAUK3HU6AQXLUIUMZ74DQMDP5EBDXA5CNFSM4H4MLWCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4R7JQ#issuecomment-507060134, or mute the thread https://github.com/notifications/unsubscribe-auth/AAUK3HWERARWQY3XQRVHD73P5EBDXANCNFSM4H4MLWCA .

mixmix commented 5 years ago

Pulled this down, tried running tests but got some errors. Saw there was a warning about "this test only works when there's a network". Not sure what that means... I'm on a wifi but still seeing errors.

I also saw there was a big warning about the default caps in cap.js ... I removed the DEVELOPMENT thing from the default caps there and deleted that warning and TODO ... is that helpful?

Was going to publish if tests passed, but don't have enough context to push this forward. Can you advise @dominictarr ?

dominictarr commented 5 years ago

okay I changed the cb of openInvite so that it only callsback a single arg, which makes it work over muxrpc. It's a breaking change though, but so was changing the caps. the tests were passing for me... failed on travis, but then I reinstalled and now they fail for me the same way...

dominictarr commented 5 years ago

okay I figured it out, an error introduced in flumeview-query@7.2, fixed in flumeview-query@7.2.1

dominictarr commented 5 years ago

merged into 2.0.0