Closed staltz closed 7 years ago
oh oops! that was definitely unintentional! that would have been to disable the rest of the tests, so they didn't clutter the output while working on something at the start. shouldn't have been committed.
Thanks dominic
Why was this
return
added to the tests? https://github.com/ssbc/ssb-ref/blob/a2131313df34e548fcc35e8fd90347eec81f926d/test/index.js#L32It turns off the IPv4 tests and now the line
in
parseMultiServerAddress
will not work for IPv4 addresses. E.g. givendata[0] = ['net', '123.123.123.1', '8008']
,host
will be''
.This directly affects code above in the SSB stack, for instance when generating an invite code, it will miss the host part.