search

ssbc / ssb-ref

check if a string is a valid ssb-reference
MIT License
14 stars 10 forks source link

check that references use canonical base64 #21

Closed dominictarr closed 5 years ago

dominictarr commented 5 years ago

for base64 strings that represent a byte string not a multiple of 3 bytes long, check that overhanging chars correctly encode zeros at the overhang. uses http://npm.im/canonical-base64

dominictarr commented 5 years ago

@christianbundy thanks, merged into 2.12.1

dominictarr commented 5 years ago

@christianbundy thanks, merged into 2.12.1

dominictarr commented 5 years ago

@christianbundy thanks, merged into 2.12.1

dominictarr commented 5 years ago

oops, this actually breaks scuttlebot tests...

dominictarr commented 5 years ago

I merged this, then I realized I broke everything... because it use '#' for the msg sigil and not '%' and there was no test coverage for that! (but linked it into scuttlebot broke quickly, though the problem wasn't obvious) fixed that, and it's now published as 12.2.2