search

ssbc / ssb-ref

check if a string is a valid ssb-reference
MIT License
14 stars 10 forks source link

getKeyFromAddress #22

Closed dominictarr closed 5 years ago

dominictarr commented 5 years ago

In the effort of making multiserver addresses the primary way to reference servers, I have implemented a better definition of valid multiserver addresses - in the multiserver-address module. I now wish to have code that was processing multiserver addresses in their own adhoc way to at least use a consistent module for it. (even better, to just treat them as opaque and not parse them) so first thing is adding getKeyFromAddress. I also have put deprecation warnings (they only print once, to standard error) for the parse* methods.

@arj03 @regular @pietgeursen

regular commented 5 years ago

github seems to be broken for me today, I can't comment on the code directly it seems ..

This looks like being a left over from before you made the deprecate() decorator:

var parseMultiServerAddress = deprecate('ssb-ref.parseMultiServerAddress', function (data) {
  if(!log_deprecated) {
    log_deprecated = true
    console.error('deprecated: parseMultiServerAddress')
  }
regular commented 5 years ago

github seems to be broken for me today, I can't comment on the code directly it seems ..

This looks like being a left over from before you made the deprecate() decorator:

var parseMultiServerAddress = deprecate('ssb-ref.parseMultiServerAddress', function (data) {
  if(!log_deprecated) {
    log_deprecated = true
    console.error('deprecated: parseMultiServerAddress')
  }
regular commented 5 years ago

github seems to be broken for me today, I can't comment on the code directly it seems ..

This looks like being a left over from before you made the deprecate() decorator:

var parseMultiServerAddress = deprecate('ssb-ref.parseMultiServerAddress', function (data) {
  if(!log_deprecated) {
    log_deprecated = true
    console.error('deprecated: parseMultiServerAddress')
  }
regular commented 5 years ago

github seems to be broken for me today, I can't comment on the code directly it seems ..

This looks like being a left over from before you made the deprecate() decorator:

var parseMultiServerAddress = deprecate('ssb-ref.parseMultiServerAddress', function (data) {
  if(!log_deprecated) {
    log_deprecated = true
    console.error('deprecated: parseMultiServerAddress')
  }
regular commented 5 years ago

github seems to be broken for me today, I can't comment on the code directly it seems ..

This looks like being a left over from before you made the deprecate() decorator:

var parseMultiServerAddress = deprecate('ssb-ref.parseMultiServerAddress', function (data) {
  if(!log_deprecated) {
    log_deprecated = true
    console.error('deprecated: parseMultiServerAddress')
  }
regular commented 5 years ago

github seems to be broken for me today, I can't comment on the code directly it seems ..

This looks like being a left over from before you made the deprecate() decorator:

var parseMultiServerAddress = deprecate('ssb-ref.parseMultiServerAddress', function (data) {
  if(!log_deprecated) {
    log_deprecated = true
    console.error('deprecated: parseMultiServerAddress')
  }
dominictarr commented 5 years ago

thanks @regular, fixed

dominictarr commented 5 years ago

merged into 2.13.0 and scuttlebot-release@13.0.0-4