search

ssbc / ssb-ref

check if a string is a valid ssb-reference
MIT License
14 stars 10 forks source link

Use `console.trace` on deprecation notice #23

Closed christianbundy closed 5 years ago

christianbundy commented 5 years ago

I noticed "deprecated api used:ssb-ref.parseMultiServerAddress" in my npm test logs but couldn't determine where it was coming from, so I monkey-patched this and it became much easier.

Before

deprecated api used:ssb-ref.parseMultiServerAddress

After

Trace: deprecated api used: ssb-ref.parseMultiServerAddress
    at /home/christianbundy/src/ssb-ref/index.js:85:15
    at parseMultiServerInvite (/home/christianbundy/src/ssb-ref/index.js:254:14)
    at exports.isMultiServerInvite (/home/christianbundy/src/ssb-ref/index.js:211:14)
    at exports.isInvite (/home/christianbundy/src/ssb-ref/index.js:217:36)
    at Object.exports.type (/home/christianbundy/src/ssb-ref/index.js:288:13)
    at exports.isLink (/home/christianbundy/src/ssb-markdown/node_modules/ssb-msgs/index.js:129:24)
    at /home/christianbundy/src/ssb-markdown/node_modules/ssb-msgs/index.js:118:35
    at Array.filter (<anonymous>)
    at Object.exports.links.exports.asLinks (/home/christianbundy/src/ssb-markdown/node_modules/ssb-msgs/index.js:118:6)
    at Test.<anonymous> (/home/christianbundy/src/ssb-markdown/test/index.js:50:10)

@dominictarr Is this too loud? I love that it only appears once, that was a great call.

dominictarr commented 5 years ago

go ahead and merge, I'm about to board a plane