ssbc / ssb-ref

check if a string is a valid ssb-reference
MIT License
14 stars 10 forks source link

Still accepts noncanonic base64 #25

Closed AljoschaMeyer closed 5 years ago

AljoschaMeyer commented 5 years ago

The hash &sha252shasa2sha2sha252shasa2sha25sha252shas=.sha256 is valid, whereas &sha252shasa2sha2sha252shasa2sha25sha252shar=.sha256 is invalid (the last character of the base64 encoding is non-canonic). ref.isLink accepts both though.

Version 2.13.3

dominictarr commented 5 years ago

fixed in 2.13.4