Closed stripedpajamas closed 5 years ago
one idea is to keep the deprecation warning on parseMultiServerAddress, but have parseMultiServerAddress call _parseMultiServerAddress (move the logic there), and _parseMultiServerAddress can be called internally without warning.
I think that's a great idea, I'd merge that PR. :tada:
Opened #29
Resolved by #29!
I got the
deprecated api used: ssb-ref.parseMultiServerAddress
message recently and looked at the stack, only to find that the offending package was ssb-ref 😢in ssb-ref:
type()
callsisInvite()
callsisMultiServerInvite()
callsparseMultiServerAddress()
should this function be marked as deprecated if the package itself is using it? if the goal is to warn others from calling parseMultiServerAddress, one idea is to keep the deprecation warning on parseMultiServerAddress, but have parseMultiServerAddress call _parseMultiServerAddress (move the logic there), and _parseMultiServerAddress can be called internally without warning.