Add support for different feed types

ssbc / ssb-ref

check if a string is a valid ssb-reference

MIT License

14 stars 10 forks source link

Add support for different feed types #34

Open christianbundy opened 5 years ago

christianbundy commented 5 years ago

This API was assuming that we could translate bytes from public keys to full feed identifiers (with the ed25519 feed type), which isn't possible with other feed types. I've just removed all parts of the API that depend on an implicit feed type, but I'm assuming that we need some of them? I'm looking for input on which exports we can safely remove. The removed exports are:

parseLegacyInvite()
parseInvite()
feedIdRegex
toAddress()

arj03 commented 3 years ago

@christianbundy I would like to help review this. Can you bring the PR up to date with latest master? :)

mixmix commented 3 years ago

This invite parsers could be moved into ssb-invite I guess?

I think if you're wanting to generalize then don't we need to come up with a new flexible format?