search

ssbc / ssb-ref

check if a string is a valid ssb-reference
MIT License
14 stars 10 forks source link

How should feed-type-assuming methods be deprecated? #35

Open christianbundy opened 4 years ago

christianbundy commented 4 years ago

This module contains a handful of methods that assume a feed type of ed25519, which won't be able to support other feed types. Should these be removed from the repo, or should we give the user the option to specify the feed type they want to use?

For example: getKeyFromAddress(addr): multiserver addresses only give a public key integer, but this method promises to return a feed type

See also: #34

dominictarr commented 4 years ago

hmm, probably need to look at what uses this api. do those things really need a concept of a feed?