Closed christianbundy closed 3 years ago
Looks good. I'm always a bit wary about changing regular expressions because they are so hard to read, but the changes looks innocent enough. If the tests parses I'm good with a merge.
Wow, didn't realize that we don't have Travis on this repo! I'll add a PR for that too. Wild.
Tests are passing locally for me with 16567ac. :taco:
I'm gonna force-push to see if I can get Travis to build the branch... custom trigger isn't working.
:boom:
Merged and publish as 2.14.2
This codebase has a handful of unused functions, empty block statements, and unused backslash characters that do nothing. These features add noise to our syntax and semantics and make the module harder to work on.
This commit applies the recommended ESLint rules, which are a bare minimum ruleset with only the most conservative best practices.