ssbc / ssb-schema-definitions

Standardised schema definitions for ssb message types using is-my-json-valid
3 stars 1 forks source link

Add test for recps and add mention support #3

Open christianbundy opened 4 years ago

christianbundy commented 4 years ago

This resolves #2, which complains that mention-style recps are invalid, although they seem to be used in the wild. The fix was just un-commenting a line of code, so I've also added a test (and run standard --fix) as well.

mixmix commented 4 years ago

I think this is a bad idea to add mention-like messages in here. My suspicion is that this definition slipped in when kieran made this module perhaps because he didn't understand recps? I could be wrong.

My main question which holds me back on this @christianbundy is :

My gut feeling is allowing people to do this is confusing, and I think supporting it is a bad idea. I think mentions should be in the mentions field... and recps should be simple. BUT it could just be familiarity talking. Where did you see this in the wild, and what are your feels?

christianbundy commented 4 years ago

Sent you a private message with some examples about where I've seen it, but in summary:

I'm using this schema definition two different ways, and I think there are maybe different needs, but I'd like to prioritize the descriptive need:

What do you think?

mixmix commented 4 years ago

NICE, I like that descriptive / prescriptive thing @christianbundy