Open christianbundy opened 4 years ago
I think this is a bad idea to add mention-like messages in here. My suspicion is that this definition slipped in when kieran made this module perhaps because he didn't understand recps? I could be wrong.
My main question which holds me back on this @christianbundy is :
recps
field, do they automatically get encrypted to the same way they do if you put just a feedId in?My gut feeling is allowing people to do this is confusing, and I think supporting it is a bad idea. I think mentions should be in the mentions field... and recps should be simple. BUT it could just be familiarity talking. Where did you see this in the wild, and what are your feels?
Sent you a private message with some examples about where I've seen it, but in summary:
recps
array it common in the wild, about 20% of the private messages I can see have this pattern{ link, name }
pattern exclusivelyI'm using this schema definition two different ways, and I think there are maybe different needs, but I'd like to prioritize the descriptive need:
recps
rule, which I'd like to be more loose.recps
to be an array of strings. What do you think?
NICE, I like that descriptive / prescriptive thing @christianbundy
This resolves #2, which complains that mention-style
recps
are invalid, although they seem to be used in the wild. The fix was just un-commenting a line of code, so I've also added a test (and runstandard --fix
) as well.