ssbc / ssb-server

The gossip and replication server for Secure Scuttlebutt - a distributed social network
1.69k stars 164 forks source link

sbot creates invalid invites. #526

Closed 20-Charisma closed 5 years ago

20-Charisma commented 6 years ago

sysinfo: OS: Windows 2012 R2

Using "sbot invite.create 1" create an invalid invite code. As a proper invite key should be: ::~ Creating an invite creates something similar to this: ::~ missing hostname and it's id.

In the image, yes it does say to create 1000 invites (Big community) anywho, this error happens with any amout of invites created... not just 1 or 1000. test

Steps to reproduce: ~Setup Win2012R2 host ~Install Node JS ~npm install scuttlebot ~sbot server --host --port ~sbot invite.create 1

christianbundy commented 6 years ago

sysinfo: OS: Windows 2012 R2

Using sbot invite.create 1 create an invalid invite code.
As a proper invite key should be: <host>:<port>:<ID>~<code>
Creating an invite creates something similar to this: <port>:~<code> missing hostname and it's id.

In the image, yes it does say to create 1000 invites (Big community) anywho, this error happens with any amout of invites created... not just 1 or 1000.

test

Steps to reproduce:

  • Setup Win2012R2 host
  • Install Node JS
  • npm install scuttlebot
  • sbot server --host <host> --port <port>
  • sbot invite.create 1

Hey @campydirt! Sorry to hear you're having issues with those invite codes. I'd love some more information on which Node version you're using, plus the output of sbot getAddress if you can. For example, here's what it looks like for me:

$ sbot getAddress
"net:192.168.0.109:8008~shs:+oaWWDs8g73EZFUMfW37R/ULtFEjwKN/DczvdYihjbU="

I'm not sure whether it matters, but if you can I'd love to see your hostname in case you're using something I'm unfamiliar with. Based on your screenshot it looks like your port number is 8008, but please correct me if I'm wrong. Thanks!

20-Charisma commented 6 years ago

So, yes, port is 8008, thought that was the default port... My node version is 8.9.4, NPM version is 5.6.0 The pub's hostname is "lithium.pub" @Q5GNre/YA9gMGr/rl5CmuCpHjQl+2z80BhEOXQQfYr0=.ed25519 When using "sbot getAddress" It returned an error: "unexpected end of parent stream"

20-Charisma commented 6 years ago

On a side note of all of this, made the valid invite code, and it says that I cant connect to the pub. But on the left side of Patchwork under (Connected pubs) You'll see my pub is connected just fine and is online...

staltz commented 6 years ago

Can you install multiserver@1.13.3 and retry in sbot?

20-Charisma commented 6 years ago

npm i multiserver? Or is it software? If its npm, I installed it and sbot invite.create 1 did the same thing.

christianbundy commented 6 years ago

@campydirt

Yeah, so if you've installed sbot globally (npm i -g scuttlebot) I think you'll also need to run npm i -g multiserver, although I'm not 100% sure. Can you verify how you're running sbot -- whether that's from a global install or a local node_modules?

20-Charisma commented 6 years ago

I can confirm that both modules are installed globally.

derekchiang commented 6 years ago

I can confirm that I'm running into this problem on ubuntu 18.04 as well. I'm running it from a global install and npm i -g multiserver does not help.

christianbundy commented 6 years ago

@derekchiang Just to clarify, are you having an issue with creating an invite code or with sbot getAddress too?

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.